Here's the Address of Contaminated Water sheet with the custom ID's - it's the sample of the end product
anytime π«‘ lemme know if you need anything else! I'll try and get the other excel sheets ready like the one above^ but as examples of the output for each of the remaining 8-9 templates
gmorning, that sheet worked nicely!
I'm ready for the other sheets with their custom ID's π€
deal, gimme like acouple minutes and I'll send em over
I haven't gotten started on the code to un-format the google sheet yet though, cuz I've had to do some other priority things, so just a heads up as well
right now, I'm just getting a better picture on how we're gonna handle this diff checking stuff
ohhhh ok perfect, and ok that works out perfect for me then so we're golden π:skintone3:
ok so i ran a test that took all those question id's and tried to look them up on the GCP columns
a question id c-24159 ("OtherType of Facility") was not found in the GCP columns. What could cause this to happen?
is that the only one for 'Other Type of Facility' that's not showing up? I think there's 15 of them
Honestly, it's probably that dustin needs to either pull the updates questions or something into the database. We updated the questions like 3 months ago, so he probably just hasn't updated the bigquery database since then regarding the questions
it's the first one i ran into and failed the test
thanks for checking that!
ok i'll have a chat with them
lemme know if you run into any other ones, it might just specifically be the 'Other Type of Facility' questions as those were added more recently
Ok so turns out their script was implicitly filtering out the columns without any answers to them. After Dustin updated his script, it was revealed that there were supposed to be more questions on their output file
TL;DR they updated their script to include empty columns, and now all my unit tests pass (confirmed that all question id's from your templates are in their excel file)
awesome, thank you! at least it's all added now π
so from here, I'm gonna make some mock data with the assumption that a column will contain the "1 of 13" in them
what are you planning to call this column?
anything we want to, I was just gonna probably name it 'Count' or something
something where I won't be like 'wtf is this' cuz i forget what it is honestly
@Josh Josue just a heads up, brittany just told me we have to add questions to the AFFF case type, so we'll probably be doing that over the next couple days, it'll affect my reformatter and what you're doing too but i'll give you the custom ID whenever it's made π:skintone3:
hi Aiden, so i forgot that the question id's have the curly braces, there's no need for a delimiter
e.g.
AFFF-contaminated water 2: Zip code of location where exposed to AFFF-contaminated water (residence, school, workplace, military base, etc):{{Custom23723}}
^this format would work just fine
gotcha, that works for me too, thank you! π
so wait, I was going to reconstruct the 10 different excel files, are you saying it'd be easier for you if it was all into 1 file?
if it's 1 file, but multiple sheets would that make any difference in regards to the ease of doing this? or would it be the same as different files basically
hmm... um what do u mean by 1 file but multiple sheets?
like, the 1 file contains all the sheets you sent me right?
Yeah, like I sent them to you as different files (each with 1 sheet), but I want to see if I can send you them as 1 excel file, with 1 different sheets/tabs within that 1 file.
Thereβs like multiple βDirect Exposure 16+β questions thatβs like a βcatch allβ if they go above 16 locations so I have to see how I can deal with those questions when formatting them back into the format that you need
ohh that tabs, i misunderstood. by 1 file i thought they would all be merged together
if it's the caase that it's 1 excel file with multiple tabs, i would prefer the multiple excel files scenario
Gotcha gotcha, Iβll see what I can do but Iβll keep you updated on it
so I talked with Nick, i dont think we'll need that column with "1 or 5" on it
Hey man, any update on the excel files with question id's appended to column names?
Oh shit, no I actually forgot about it cuz Brittany had me pivot to something else, but I finished it a bit ago, so I will work on these and have them to you by tomorrow-ish
Sorry dude, Iβm a wreck lol I mean this place is a wreck, and Iβm playing catch up with all the stuff to fix π
Lol naw i get it. But i appreciate ya for adding those question idβs! π
@Josh Josue here's the documents π I haven't started the code yet, they've been working me like a horse but i have time today so ima get it started now
Thanks dude! I'll be able to run more tests with these
so I found out it's only because they're headers, if I give you the excel back in csv format it should have all the characters
do you know specifically which headers were cut off? or at least which sheet/excel file it was in?
β’ Address of Contaminated Water β’ Direct Exposure Product Information β’ Direct Exposure Product Information
In order to update the questions, do you need the output questions to match exactly what the questions in LR are? like does it matter if they're changed a little?
the question wording doesnt matter
okay perfect, and it'll still have the custom id so we're golden
the thing that matters the most is that there's a question id per question
gotcha, yeah we got that down π:skintone3:
when you get the chance, could i plz have the updated versions of those 3 files: β’ Address of Contaminated Water β’ Direct Exposure Product Information β’ Direct Exposure Product Information
I haven't finished them up, but I will probably get them to you some time tomorrow if that's okay? sorry!
I do not, I'm sorry, I'm still working out some kinks with the code - do you just want an example of what the output will look like? cuz I can manually edit one of the older ones if you'd like and send it over to you
oh ok, then could i plz have the question id's for the last columns of those 3 files?
i'll manually type em in for testing purposes
Address of Contaminated Water 16+ question - {{Custom23963}} Direct Exposure Address History 16+ question - {{Custom24193}} Direct Exposure Product Information 6+ question - {{Custom24242}}
are these the right ones? cuz you put Direct Exposure Product Information twice
oh sorry, but yea these are the ones i need, thanks!
Hey @Josh Josue can I give you like 1 or 2 and let me know if it'd work? don't like actually update the info - but would this layout work? these are how they'd be output through my code: These are just rough drafts, i have to make sure there are no weird things happening with the text and such, if there is we can't have it uploading the weird stuff to lawruler
just make sure to don't actually use these to update anything in lawruler plz! lol
yea, they told me that Dustin's web portal would make the updates
I'm just working on a thing that checks the differences between GCP entries and your guys' excel files
so i noticed that these excel files' first column is "Plaintiff Number"
is this going to be the new template column names?
Ahhh gotcha gotcha, that makes more sense now for some reason I thought you were directly updating lawruler, I misunderstood
And I can change it back to Lead ID, idk why itβs plaintiff number - Iβm still working on a couple things but this is the general layout for how theyβll be output
The ones without {{Custom#####}} in the headers are blank columns/filler columns - theyβre just needed for spacing so you can ignore the ones without custom idβs
*Thread Reply:* awesome! yea bcuz I've only been checking diffs for columns with {{Custom####}} haha
but yeah, i think everything else is looking good
okay PERfect, that's awesome, I'm thinking of possibly automating the 'sending it to you' part and just sending it in an email to you, so if you're able to have it so that it checks your email for any unread email with 'xyz' subject - did you want me to do that?
i leave in like 6 minutes, but we can talk more about that tomorrow or something if you want - cuz the audits that they do are inconsistent time-wise so i'd have to manually execute it, but you might be able to set it up so that it checks your email for an unread email (with a subject that we determine at a later date) and executes when that email is received - but idk, there might be easier ways to do that
the actual usecase is a User uploading these excel files onto webportal
ooh i didn't know that's how it'd work! yeah, we'll talk tomorrow, thank you! π«‘
I've noticed some questions have {{Default###}}
For example "Date of Death {{Default91}}" from Initial PFS Data_2025-06-09
Those are default fields - so instead of like c-12345 , it'd be like d-14 for the custom id
If that field isnt found on Big Query, does it mean that it was recently added?
Ohhh - ok Iβll look into this
thank you! lemme know what he says, cuz we haven't added any more default fields (to my knowledge) for like 6+ months
the field might also jsut be the number for the default ones
Dustin gave me a table of the default fields. I was able to account for them now
okay perfect! thank you! I'm still working on some final tweaks, but it seems to be fine right now