@Dustin Surwill has joined the channel
@Richard Schnitzler has joined the channel
@Daniel Schussler has joined the channel
@Carter Matzinger has joined the channel
set the channel description: Payload Mapping QA Channel: Reviewing Integrations before a go live
*Thread Reply:* Approved, new Page created
*Thread Reply:* No Ids in Docs, no file in sharepoint, no apparent issues
*Thread Reply:* according to the google sheet, the parent matter and case type id are correct
*Thread Reply:* Approved Doc Created
*Thread Reply:* Approved, doc created
No Ids in Docs, no file in sharepoint, no apparent issues
thank you
MI Clergy Abuse Yih - Payload (Case Type: 2118).
*Thread Reply:* Approved, created Doc https://dicellolevitt.atlassian.net/wiki/spaces/shl/pages/72482831/Illinois+Juv+Hall+Abuse+TV+-+DL_BG+-+Flatirons+-+Shield+Legal+-+1717
MI Juv Hall Abuse - SGGH - Meadow - Yih - Shield Legal (Case Type ID: 2120)
*Thread Reply:* Line 178 has '\u00a0' in a question text
MI Juv Hall Abuse OSOL - SGGH - Meadow - Yih - Shield Legal
Line 178 has '\u00a0' in a question text
MI YRTC Abuse OSOL - SGGH - Meadow - Yih - Shield Legal (Case Type ID: 2122)
MI YRTC Abuse OSOL - SGGH - Meadow - Yih - Shield Legal (Case Type ID: 2121)
PFAS Water Contamination - Aaron - ELG - Shield Legal (Case Type ID: 2133)
*Thread Reply:* It looks pretty good. I'm assuming that the main has the first name take everything up until the first space and the last name taking everything after the last space?
emergency contact fields look like this:
"alternateContacts": [
{
"firstName": "TEST:",
"middleName": "Emergency Contact",
"lastName": "Name:",
"mobilePhone": "<tel:(555)531-5444|(555) 531-5444>",
"relationshipToInjured": "Spouse"
}
*Thread Reply:* Looks Good! Approved! HOWEVER, I don't see Mother or Father on approved Roles, do we need to update the Page?
*Thread Reply:* Yeah probably. The questionnaire asks for name and date of birth. Abe would want those roles
Looks Good! Approved! HOWEVER, I don't see Mother or Father on approved Roles, do we need to update the Page?
MI Clergy Abuse - Ghozland - SGGH - Meadow - Shield Legal
MI Clergy Abuse - AFG - SGGH - Meadow - Shield Legal
*Thread Reply:* Looks good! Approved!
Correction for 2073 @Dwight Thomas
"Q:c18981_:Other loot:": "Signer is unsure.",
Is this properly formatted?
"CASECOMMENTS": "Anti-Social Disorder (Not diagnosed but experiences symptoms) - Nervous, does not like being around people\nSocial Phobia (Not diagnosed but experiences symptoms)\n_Panic Disorder (Not diagnosed but experiences symptoms) - Makes his hands clench hard and start shaking"
Should these newline (\n) characters be included with the data?
That was my understanding, @Dustin Surwill?
I want to make a suggestion as it relates to QA...
We should add two columns to the Monday API Integrations board for "Payload QA Assignee" and "Law Ruler QA Assignee"
It helps track who provided the QA responsibilities for each campaign as well as makes it easier to ask direct questions of that individual.
*Thread Reply:* Looks good to me!
*Thread Reply:* Unicode for ZWS and/or ♂️ No issues if it is the former
*Thread Reply:* Approved - 8/14 11:11 AM'
@Dwight Thomas @Daniel Schussler @Richard Schnitzler This doc will be the checklist to follow for payload qa. There may be some tweaks but for now follow as best you can: https://docs.google.com/document/d/18orS2h5giBLjlnZopWlt7IfcUJ60QiV2/edit
*Thread Reply:* Looks good
*Thread Reply:* 1. Can we replace \u00c2 & \u00a0 in the mapping
1959 QA Review Request
*Thread Reply:* Looks good to me! Approved!
On Illinois Juvenile Hall Abuse - Dicello - BG_Flatirons NC (TIP) - Shield Legal - 601, can we verify the Law Ruler email automation?
*Thread Reply:* There should only be 1 case type on the recipients tab which should match the one your working on
On Illinois Juvenile Hall Abuse - Dicello - BG_Flatirons NC (TIP) - Shield Legal - 601, can we verify the Law Ruler email automation?
*Thread Reply:* it looks good. Only concern i have is
"questionId": "a0PVT00000QV5km2AD",
"questionnaireId": "a0RVT000008nrOP2AY",
"answer": "5'7\" to 6\"",
"answerType": "STRING"
*Thread Reply:* but it looks like the json read it fine.
*Thread Reply:* aka approved
2152: AFFF PFAS Military Base Exposure - Nations - Levinson - TC - Shield Legal QA Review Needed
*Thread Reply:* @Richard Schnitzler / @Daniel Schussler
*Thread Reply:* date of birth field is interesting. is it suppose to be like that ?
*Thread Reply:* Looks fine to me otherwise, ~can't speak to the format of the Case~, but looks solid and in the Case Works format
*Thread Reply:* 2152: AFFF PFAS Military Base Exposure - Nations - Levinson - TC - Shield Legal QA Review Needed
Looks fine to me otherwise, ~can't speak to the format of the Case~, but looks solid and in the Case Works format
AFFF PFAS Military Base Exposure - VAM - ELG - Meadow - Shield Legal is ready for internal testing. Can someone confirm the automation please?
*Thread Reply:* • I think PFAS takes priority over AFFF for representaionType.
• The email thread I had you look at should have mentioned emailing 2 distro lists so they can get the docs since their docs endpoint is currently broken (this will be added after the testing, but keep in mind).
• Created Date is not a valid field for the mapping, does it get overwritten in the main.py?
• Here are the API docs for reference.
• using test to swap the url will not work since we stop the function when test exists for our local testing
*Thread Reply:* might be a different thread. the email thread i have is only 9 emails long with minimal info from Troy from 7/24 - 7/28.
I was just copy pasting the mapping from the other campaigns.
great so i'll remove the condition... rip.
data['fieldData']['Payload']['intakeDate'] = datetime.now().strftime('%m-%d-%Y')
data['fieldData']['Payload']['openDate'] = datetime.now().strftime('%m-%d-%Y')
data['fieldData']['Payload'] = json.dumps(data['fieldData']['Payload'])
*Thread Reply:* overwriting in the main. still weird that its hardcoded in as a string in the mapping
*Thread Reply:* but i made the adjustments
*Thread Reply:* I forwarded you the correct email thread
*Thread Reply:* ok, i'll move forward with that once the testing is completed. till then does the automation look good so i can test internally?
*Thread Reply:* yes
READY FOR QA: IL JDC Abuse - Baypoint - SGGH - Shield Legal (GCP Webhook) Automation https://tortintakeprofessionals.lawruler.com/AddEdit-Campaign.aspx?cID=2072
AFFF PFAS Military Base Exposure - Nations - Levinson - TC - Shield Legal QA Review Needed https://tortintakeprofessionals.lawruler.com/AddEdit-Campaign.aspx?cID=2061
*Thread Reply:* I have updated the main.py
2160 - AFFF PFAS Military Base Exposure - VAM - ELG - Meadow - Shield Legal
*Thread Reply:* No alternate contact?
*Thread Reply:* other than the dates looks good. I would like to a version with the corrected dates
*Thread Reply:* its the same reason as why the dates weren't overwritten
the intakedate/opendate weren't overwritten, looks like i'll just remove the hard code
*Thread Reply:* There are several screening questions that have no custom fields passed to them. I spoke to Daniel and this is to be expected.
the map look a bit different but i made it read able
if you are curious this is how the map came out this time
*Thread Reply:* If this is a test lead then test needs to be either the injured first name or injured last name. Are the empty questions empty in LR? There should not be empty questions in LR if this is a test lead
*Thread Reply:* its copied from a live lead but i changed the sensitive information
*Thread Reply:* but its still a test lead?
*Thread Reply:* Mock tester is the name
*Thread Reply:* test is in the last name
*Thread Reply:* any other feedback?
*Thread Reply:* no, i guess its good
QA REQUEST - 2150 - IL JDC Abuse - Baypoint - SGGH - Shield Legalintakepayload-Bay_Point
*Thread Reply:* test is suppose to be true right? other law firm has a # if not intended
*Thread Reply:* outside of that, it looks fine
*Thread Reply:* @Daniel Schussler new payload to QA
*Thread Reply:* Sorry for the delay have been out of it. Test is supposed to be set to true and other law firm with the # Should be over written when it goes to the main.pie process, but it was not being overwritten. I’m sorry that I couldn’t finish before I left but the food at the restaurant. I got me violently sick quick. I’m going to hop on my laptop in a few minutes and QA this payload. Thank you again.
*Thread Reply:* Also take a look at the changes in the PR. A lot changed
*Thread Reply:* Aside from the # in "discussWithOtherLawFirm" it looks fine to me
Please look over this PR before I test, the lr_questions may not be up to date since the questions were being edited today. https://github.com/shield-legal/gcp-integrations/pull/270
*Thread Reply:* Also, could someone build a test lead?
*Thread Reply:* I will tomorrow morning
*Thread Reply:* https://tortintakeprofessionals.lawruler.com/update-lead.aspx?lead=835628
AFFF PFAS Military Base Exposure - Nations - Levinson - TC - Shield Legal - Non Military PFAS-SL-TestTraining
{"Case Type": "Non Military PFAS-SL-TestTraining",
"Case SubType": "RRS-Attestation-AG Outreach",
"FirmID": "SL",
"FirmCaseNO": 827848,
"Office": "Shield Legal",
"FirstName": "Maximus",
"MiddleName": "Artillious",
"LastName": "Testing",
"MobilePhone": "